the-other-tim-brown commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2061529121
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
try {
// NOTE: This is required for idempotency
if (eof) {
+ // eagerly close
+ close();
Review Comment:
The rule you are referring to is that the hasNext does not have a
side-effect like advancing the position in the collection. That is not broken
by this change. If this is a hard line and we cannot do both here, then I can
revert these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
