danny0405 commented on code in PR #13300:
URL: https://github.com/apache/hudi/pull/13300#discussion_r2099158628
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroReaderContext.java:
##########
@@ -80,12 +89,27 @@ public ClosableIterator<IndexedRecord>
getFileRecordIterator(
long length,
Schema dataSchema,
Schema requiredSchema,
- HoodieStorage storage
+ HoodieStorage storage,
+ Option<Predicate> filter
) throws IOException {
+ HoodieFileFormat fileFormat = detectFileFormat(filePath);
HoodieAvroFileReader reader = (HoodieAvroFileReader)
HoodieIOFactory.getIOFactory(storage)
.getReaderFactory(HoodieRecord.HoodieRecordType.AVRO).getFileReader(new
HoodieConfig(),
- filePath, HoodieFileFormat.PARQUET, Option.empty());
- return reader.getIndexedRecordIterator(dataSchema, requiredSchema);
+ filePath, fileFormat, Option.empty());
+ if (!filter.isPresent() || !(reader instanceof
HoodieAvroHFileReaderImplBase)) {
Review Comment:
`!(reader instanceof HoodieAvroHFileReaderImplBase)` is enough because for
the `else` part, there is force type case, we can handle the non key filtering
cases in the else branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
