danny0405 commented on code in PR #13300:
URL: https://github.com/apache/hudi/pull/13300#discussion_r2099161948
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/FileGroupRecordBuffer.java:
##########
@@ -131,6 +145,30 @@ protected FileGroupRecordBuffer(HoodieReaderContext<T>
readerContext,
readerContext.getSchemaHandler().getCustomDeleteMarkerKeyValue().isPresent();
this.shouldCheckBuiltInDeleteMarker =
readerContext.getSchemaHandler().hasBuiltInDelete();
+
+ // Prepare filters.
+ this.filter = filter;
Review Comment:
move these filters into the record context? And it also looks weird the
passed in `filter` transformed into key-prefix look up filters here, I kind of
think the filter for FG reader should be generalized, not just specific to
HFile prefix lookup.
And the actual filter that works here `evalFilter` looks pretty much like a
key filter, can we just pass the Option key filtering `Function<String,
Boolean>` here instead, in the future, we can also support value filtering.
So my idea is we move the filter into reader context and it should be a key
filter function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
