yihua commented on code in PR #12964:
URL: https://github.com/apache/hudi/pull/12964#discussion_r2110712721
##########
pom.xml:
##########
@@ -1023,6 +927,10 @@
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>commons-lang</groupId>
+ <artifactId>commons-lang</artifactId>
+ </exclusion>
Review Comment:
Is `commons-lang` dependency still used? I assume HBase uses it only so we
can get rid of `commons-lang` dependency?
##########
pom.xml:
##########
@@ -870,6 +764,16 @@
<version>${slf4j.version}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>javax.xml.bind</groupId>
+ <artifactId>jaxb-api</artifactId>
+ <version>2.3.1</version>
+ </dependency>
Review Comment:
For `NotNull` annotation, `org.jetbrains.annotations.NotNull` should be
used. Let's fix that as a separate PR quickly?
##########
hudi-sync/hudi-datahub-sync/pom.xml:
##########
@@ -93,6 +93,13 @@
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
+ <version>${hadoop.version}</version>
+ <scope>compile</scope>
+ </dependency>
Review Comment:
The response does not answer my question. Should `hudi-hadoop-common` be
included instead if Hadoop-related classes are needed for Hudi:
```
<dependency>
<groupId>org.apache.hudi</groupId>
<artifactId>hudi-hadoop-common</artifactId>
<version>${project.version}</version>
</dependency>
```
##########
pom.xml:
##########
@@ -1875,6 +1845,11 @@
<artifactId>mbknor-jackson-jsonschema_${scala.binary.version}</artifactId>
<version>1.0.39</version>
</dependency>
+ <dependency>
+ <groupId>javax.validation</groupId>
+ <artifactId>validation-api</artifactId>
+ <version>2.0.1.Final</version>
+ </dependency>
Review Comment:
Could you check this again? Might be a mistake introducing this for
annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
