yihua commented on code in PR #12964:
URL: https://github.com/apache/hudi/pull/12964#discussion_r2110797810
##########
hudi-utilities/pom.xml:
##########
@@ -454,6 +462,11 @@
<groupId>io.confluent</groupId>
<artifactId>kafka-json-schema-provider</artifactId>
</dependency>
+ <dependency>
+ <groupId>javax.xml.bind</groupId>
+ <artifactId>jaxb-api</artifactId>
+ <version>2.3.1</version>
+ </dependency>
Review Comment:
Revisit to remove.
##########
hudi-spark-datasource/hudi-spark3.3.x/pom.xml:
##########
@@ -243,6 +243,12 @@
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
+ <version>${hadoop.version}</version>
+ </dependency>
Review Comment:
Should this be added to `hudi-spark-common` or `hudi-spark`, as `provided`
dependency? Same on `hudi-spark3.4.x` and `hudi-spark3.5.x` modules?
##########
hudi-utilities/pom.xml:
##########
@@ -216,6 +216,10 @@
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>javax.validation</groupId>
+ <artifactId>validation-api</artifactId>
+ </exclusion>
Review Comment:
Revisit to see if these exclusions can be removed.
##########
hudi-tests-common/pom.xml:
##########
@@ -201,7 +201,12 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-hdfs-client</artifactId>
<version>${hadoop.version}</version>
- <classifier>tests</classifier>
+ <scope>test</scope>
Review Comment:
Actually this change removes `hadoop-hdfs-client` from the
`hudi-tests-common` module because it has to be `compile` scope for other
module to use it in the tests. And you need `<classifier>tests</classifier>` to
have test classes in `hadoop-hdfs-client` module to be included.
##########
pom.xml:
##########
@@ -870,6 +764,16 @@
<version>${slf4j.version}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>javax.xml.bind</groupId>
+ <artifactId>jaxb-api</artifactId>
+ <version>2.3.1</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-client-runtime</artifactId>
+ <version>3.3.2</version>
Review Comment:
Should this align with `hadoop.version`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
