Davis-Zhang-Onehouse commented on code in PR #13647:
URL: https://github.com/apache/hudi/pull/13647#discussion_r2251972712
##########
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java:
##########
@@ -366,39 +359,43 @@ Map<String, List<StoragePathInfo>>
fetchAllFilesInPartitionPaths(List<StoragePat
}
/**
- * Computes a map from col-stats key to partition and file name pair.
+ * Computes raw keys and metadata for column stats lookup.
*
* @param partitionNameFileNameList - List of partition and file name pair
for which bloom filters need to be retrieved.
* @param columnNames - List of column name for which stats are needed.
+ * @return Pair of raw keys list and a map from encoded key to
partition/file pair
*/
- private Map<String, Pair<String, String>> computeColStatKeyToFileName(
+ private Pair<List<ColumnStatsIndexRawKey>, Map<String, Pair<String,
String>>> computeColStatRawKeys(
Review Comment:
RawKey is consumed by the lookup API. the Map tracks the encoded key and is
consumed by some other logic.
This can be further unified to use the raw key everywhere. For this patch I
choose to stop here to avoid the scope of refactor keep expanding. Other than
more memory consumption as we create more object, it should not have more impact
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
