Davis-Zhang-Onehouse commented on code in PR #13647: URL: https://github.com/apache/hudi/pull/13647#discussion_r2251988175
########## hudi-common/src/main/java/org/apache/hudi/metadata/BloomFilterIndexRawKey.java: ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.metadata; + +import org.apache.hudi.common.util.hash.FileIndexID; +import org.apache.hudi.common.util.hash.PartitionIndexID; + +import java.util.Objects; + +/** + * Represents a raw key for bloom filter metadata. + */ +public class BloomFilterIndexRawKey implements RawKey { + private final String partitionName; + private final String fileName; + + public BloomFilterIndexRawKey(String partitionName, String fileName) { + this.partitionName = Objects.requireNonNull(partitionName); + this.fileName = Objects.requireNonNull(fileName); + } + + @Override + public String encode() { + return HoodieMetadataPayload.getBloomFilterIndexKey( + new PartitionIndexID(HoodieTableMetadataUtil.getBloomFilterIndexPartitionIdentifier(partitionName)), + new FileIndexID(fileName)); + } + + public String getPartitionName() { Review Comment: I revised as required, and I'm confused why getXXX and setXXX as a pattern that industry has been universally applied needs to be revised here, while in code base we have a lot of getXXX pattern. ########## hudi-common/src/main/java/org/apache/hudi/metadata/RawKey.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.metadata; + +import java.io.Serializable; + +/** + * Interface for raw keys that can be encoded for storage in the metadata table. + */ Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
