yihua commented on code in PR #13726:
URL: https://github.com/apache/hudi/pull/13726#discussion_r2283574613
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -3674,4 +3675,17 @@ private String getDefaultMarkersType(EngineType
engineType) {
}
}
}
+
+ public boolean isFileGroupReaderBasedMergedHandle() {
Review Comment:
```suggestion
public boolean isFileGroupReaderBasedMergeHandle() {
```
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -3674,4 +3675,17 @@ private String getDefaultMarkersType(EngineType
engineType) {
}
}
}
+
+ public boolean isFileGroupReaderBasedMergedHandle() {
+ return isFileGroupReaderBasedMergedHandle(props);
+ }
+
+ public static boolean isFileGroupReaderBasedMergedHandle(TypedProperties
props) {
Review Comment:
```suggestion
public static boolean isFileGroupReaderBasedMergeHandle(TypedProperties
props) {
```
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -3674,4 +3675,17 @@ private String getDefaultMarkersType(EngineType
engineType) {
}
}
}
+
+ public boolean isFileGroupReaderBasedMergedHandle() {
+ return isFileGroupReaderBasedMergedHandle(props);
+ }
+
+ public static boolean isFileGroupReaderBasedMergedHandle(TypedProperties
props) {
+ try {
+ return FileGroupReaderBasedMergeHandle.class.isAssignableFrom(
+ Class.forName(ConfigUtils.getStringWithAltKeys(props,
HoodieWriteConfig.MERGE_HANDLE_CLASS_NAME, true)));
Review Comment:
nit: `ReflectionUtils#isSubClass` can be used, which leverages class cache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
