the-other-tim-brown commented on code in PR #13726:
URL: https://github.com/apache/hudi/pull/13726#discussion_r2283720487
##########
hudi-common/src/main/java/org/apache/hudi/avro/AvroRecordContext.java:
##########
@@ -110,26 +105,25 @@ public HoodieRecord
constructHoodieRecord(BufferedRecord<IndexedRecord> buffered
HoodieKey hoodieKey = new HoodieKey(bufferedRecord.getRecordKey(),
partitionPath);
if (bufferedRecord.isDelete()) {
- if (payloadClass != null) {
- return SpillableMapUtils.generateEmptyPayload(
- bufferedRecord.getRecordKey(),
- partitionPath,
- bufferedRecord.getOrderingValue(),
- payloadClass,
- bufferedRecord.getHoodieOperation());
- } else {
- return new HoodieEmptyRecord<>(
- hoodieKey,
- bufferedRecord.getHoodieOperation(),
- OrderingValues.getDefault(),
- HoodieRecord.HoodieRecordType.AVRO);
- }
+ return generateEmptyAvroRecord(
+ hoodieKey,
+ bufferedRecord.getOrderingValue(),
+ payloadClass,
+ bufferedRecord.getHoodieOperation());
}
- if (requiresPayloadRecords) {
- HoodieRecordPayload payload =
HoodieRecordUtils.loadPayload(payloadClass, (GenericRecord)
bufferedRecord.getRecord(), bufferedRecord.getOrderingValue());
- return new HoodieAvroRecord<>(hoodieKey, payload,
bufferedRecord.getHoodieOperation(), bufferedRecord.isDelete());
+
+ return HoodieRecordUtils.createHoodieRecord((GenericRecord)
bufferedRecord.getRecord(), bufferedRecord.getOrderingValue(),
+ hoodieKey, payloadClass, bufferedRecord.getHoodieOperation(),
Option.empty(), false);
Review Comment:
Right now the only place we have BufferedRecords is the AvroRecordContext so
it is not as applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
