the-other-tim-brown commented on code in PR #13726:
URL: https://github.com/apache/hudi/pull/13726#discussion_r2283795609


##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieAvroIndexedRecord.java:
##########
@@ -197,17 +215,18 @@ public HoodieRecord truncateRecordKey(Schema 
recordSchema, Properties props, Str
 
   @Override
   protected boolean checkIsDelete(Schema recordSchema, Properties props) {
+    decodeRecord(recordSchema);
     if (getData().equals(SENTINEL)) {
       return false; // Sentinel record is not a delete
     }

Review Comment:
   That would require us to serialize the schema which will increase the size 
of the serialized record



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to