prashantwason commented on a change in pull request #2332: URL: https://github.com/apache/hudi/pull/2332#discussion_r544054515
########## File path: hudi-client/src/main/java/org/apache/hudi/client/HoodieWriteClient.java ########## @@ -701,8 +704,6 @@ protected void completeCompaction(HoodieCommitMetadata metadata, JavaRDD<WriteSt finalizeWrite(table, compactionCommitTime, writeStats); LOG.info("Committing Compaction " + compactionCommitTime + ". Finished with result " + metadata); - table.metadataWriter(jsc).update(metadata, compactionCommitTime); - Review comment: Clarification: Since we are not updating the metadata table here, for compactions the metadata table will be updated the next time the HoodieWriteClient is created. But for commit operations the metadata table (may) be updated right after the commit completes in "postCommit" function. Right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org