prashantwason commented on a change in pull request #2332:
URL: https://github.com/apache/hudi/pull/2332#discussion_r544072468



##########
File path: 
hudi-client/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -725,6 +698,13 @@ private synchronized void commit(JavaSparkContext jsc, 
JavaRDD<HoodieRecord> rec
           throw new HoodieMetadataException("Failed to commit metadata table 
records at instant " + instantTime);
         }
       });
+      // trigger cleaning, compaction, with suffixes based on the same instant 
time. This ensures that any future
+      // delta commits synced over will not have an instant time lesser than 
the last completed instant on the
+      // metadata table.
+      writeClient.clean(instantTime + "001");

Review comment:
       This is a good idea. I hope it does not break some function which may 
depend on yyyyMMddHHmmss format of the instantTime.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to