rahil-c commented on code in PR #13735:
URL: https://github.com/apache/hudi/pull/13735#discussion_r2366284500
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1011,7 +1011,7 @@ public String
startDeletePartitionCommit(HoodieTableMetaClient metaClient) {
*/
@VisibleForTesting
String startCommit(Option<String> providedInstantTime, String actionType,
HoodieTableMetaClient metaClient) {
- if (needsUpgrade(metaClient)) {
+ if (UpgradeDowngrade.needsUpgrade(metaClient, config,
config.getWriteVersion())) {
Review Comment:
this seems unnecessary right to have another param for write version since
we are already passing the config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
