rahil-c commented on code in PR #13735:
URL: https://github.com/apache/hudi/pull/13735#discussion_r2366285322


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1011,7 +1011,7 @@ public String 
startDeletePartitionCommit(HoodieTableMetaClient metaClient) {
    */
   @VisibleForTesting
   String startCommit(Option<String> providedInstantTime, String actionType, 
HoodieTableMetaClient metaClient) {
-    if (needsUpgrade(metaClient)) {
+    if (UpgradeDowngrade.needsUpgrade(metaClient, config, 
config.getWriteVersion())) {

Review Comment:
   [nit] At some point we should refactor the need of passing 
config.writeVersion, since we are already passing config.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to