yanghua commented on a change in pull request #2430: URL: https://github.com/apache/hudi/pull/2430#discussion_r559339305
########## File path: hudi-flink/src/main/java/org/apache/hudi/streamer/Config.java ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.streamer; + +import org.apache.hudi.common.model.OverwriteWithLatestAvroPayload; +import org.apache.hudi.common.model.WriteOperationType; +import org.apache.hudi.keygen.SimpleAvroKeyGenerator; + +import com.beust.jcommander.Parameter; +import org.apache.flink.configuration.Configuration; + +import java.util.ArrayList; +import java.util.List; + +/** + * Configurations for Hoodie Flink streamer. + */ +public class Config extends Configuration { + @Parameter(names = {"--kafka-topic"}, description = "kafka topic", required = true) + public String kafkaTopic; + + @Parameter(names = {"--kafka-group-id"}, description = "kafka consumer group id", required = true) + public String kafkaGroupId; + + @Parameter(names = {"--kafka-bootstrap-servers"}, description = "kafka bootstrap.servers", required = true) Review comment: There are many minor issues for the description items of these config options, e.g., describe it with a normal sentence(take care of the grammar?), Upper the first letter? In short, keep consistent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
