danny0405 commented on a change in pull request #2430: URL: https://github.com/apache/hudi/pull/2430#discussion_r559431761
########## File path: hudi-flink/src/main/java/org/apache/hudi/operator/StreamWriteOperatorCoordinator.java ########## @@ -0,0 +1,419 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.operator; + +import org.apache.hudi.client.FlinkTaskContextSupplier; +import org.apache.hudi.client.HoodieFlinkWriteClient; +import org.apache.hudi.client.WriteStatus; +import org.apache.hudi.client.common.HoodieFlinkEngineContext; +import org.apache.hudi.common.fs.FSUtils; +import org.apache.hudi.common.model.HoodieTableType; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.exception.HoodieException; +import org.apache.hudi.operator.event.BatchWriteSuccessEvent; +import org.apache.hudi.util.StreamerUtil; + +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.core.memory.DataInputViewStreamWrapper; +import org.apache.flink.core.memory.DataOutputViewStreamWrapper; +import org.apache.flink.runtime.jobgraph.OperatorID; +import org.apache.flink.runtime.operators.coordination.OperatorCoordinator; +import org.apache.flink.runtime.operators.coordination.OperatorEvent; +import org.apache.flink.util.Preconditions; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.jetbrains.annotations.Nullable; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.ByteArrayInputStream; +import java.io.ByteArrayOutputStream; +import java.io.DataInputStream; +import java.io.DataOutputStream; +import java.io.IOException; +import java.util.Arrays; +import java.util.Collection; +import java.util.HashMap; +import java.util.List; +import java.util.Objects; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.CompletionException; +import java.util.concurrent.TimeUnit; +import java.util.stream.Collectors; + +/** + * {@link OperatorCoordinator} for {@link StreamWriteFunction}. + * + * <p>This coordinator starts a new instant when a new checkpoint starts. It commits the instant when all the + * operator tasks write the buffer successfully for a round of checkpoint. + * + * <p>If there is no data for a round of checkpointing, it rolls back the metadata. + * + * @see StreamWriteFunction for the work flow and semantics + */ +public class StreamWriteOperatorCoordinator + implements OperatorCoordinator { + private static final Logger LOG = LoggerFactory.getLogger(StreamWriteOperatorCoordinator.class); + + /** + * Config options. + */ + private final Configuration conf; + + /** + * Write client. + */ + private transient HoodieFlinkWriteClient writeClient; + + private long inFlightCheckpoint = -1; + + /** + * Current REQUESTED instant, for validation. + */ + private String inFlightInstant = ""; + + /** + * Event buffer for one round of checkpointing. When all the elements are non-null and have the same + * write instant, then the instant succeed and we can commit it. + */ + private transient BatchWriteSuccessEvent[] eventBuffer; + + /** + * Task number of the operator. + */ + private final int parallelism; + + /** + * Constructs a StreamingSinkOperatorCoordinator. + * + * @param conf The config options + * @param parallelism The operator task number + */ + public StreamWriteOperatorCoordinator( + Configuration conf, + int parallelism) { + this.conf = conf; + this.parallelism = parallelism; + } + + @Override + public void start() throws Exception { + // initialize event buffer + reset(); + // writeClient + initWriteClient(); + // init table, create it if not exists. + initTable(); + } + + @Override + public void close() { + if (writeClient != null) { + writeClient.close(); + } + this.eventBuffer = null; + } + + @Override + public void checkpointCoordinator(long checkpointId, CompletableFuture<byte[]> result) { + try { + final String errMsg = "A new checkpoint starts while the last checkpoint buffer" + + " data has not finish writing, roll back the last write and throw"; + checkAndForceCommit(errMsg); + this.inFlightInstant = this.writeClient.startCommit(); + this.inFlightCheckpoint = checkpointId; + LOG.info("Create instant [{}], at checkpoint [{}]", this.inFlightInstant, checkpointId); + result.complete(writeCheckpointBytes()); + } catch (Throwable throwable) { + // when a checkpoint fails, throws directly. + result.completeExceptionally( + new CompletionException( Review comment: No, this is needed by the `Flink` coordinator. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
