kbuci commented on code in PR #18191:
URL: https://github.com/apache/hudi/pull/18191#discussion_r2875883665
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/client/functional/TestHoodieClientOnCopyOnWriteStorage.java:
##########
@@ -1033,6 +1024,21 @@ public void testBinaryCopyClustering() throws Exception {
false, SqlQueryEqualityPreCommitValidator.class.getName(),
COUNT_SQL_QUERY_FOR_VALIDATION, "");
}
+ /**
+ * Tests clustering when {@code hoodie.clustering.plan.partition.parallel}
is disabled (non-default).
+ * Ensures the code path that computes clustering groups on the driver
serially (HoodieLocalEngineContext) is exercised.
+ */
+ @ParameterizedTest
+ @MethodSource("populateMetaFieldsParams")
+ public void
testClusteringWithComputePlanPerPartitionParallelDisabled(boolean
populateMetaFields) throws Exception {
+ initMetaClient(getPropertiesForKeyGen(populateMetaFields));
+ HoodieClusteringConfig clusteringConfig = createClusteringBuilder(true, 1)
+ .planPartitionParallel(false)
+ .build();
+ testInsertAndClustering(clusteringConfig, populateMetaFields, true,
Review Comment:
Added a similar test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
