nsivabalan commented on code in PR #18217:
URL: https://github.com/apache/hudi/pull/18217#discussion_r2882308802
##########
packaging/bundle-validation/docker_java17/docker_java17_test.sh:
##########
@@ -51,49 +51,60 @@ start_datanode () {
echo "::warning::docker_test_java17.sh starting datanode:"$DN
- cat $HADOOP_HOME/hadoop/etc/hdfs-site.xml
- cat $HADOOP_HOME/hadoop/etc/core-site.xml
-
DN_DIR_PREFIX=$DOCKER_TEST_DIR/additional_datanode/
PID_DIR=$DOCKER_TEST_DIR/pid/$1
- if [ -z $DN_DIR_PREFIX ]; then
- mkdir -p $DN_DIR_PREFIX
- fi
-
- if [ -z $PID_DIR ]; then
- mkdir -p $PID_DIR
- fi
-
- export HADOOP_PID_DIR=$PID_PREFIX
+ mkdir -p $DN_DIR_PREFIX $PID_DIR
+ export HADOOP_PID_DIR=$PID_DIR
DN_CONF_OPTS="\
-Dhadoop.tmp.dir=$DN_DIR_PREFIX$DN\
-Ddfs.datanode.address=localhost:5001$DN \
-Ddfs.datanode.http.address=localhost:5008$DN \
-Ddfs.datanode.ipc.address=localhost:5002$DN"
- $HADOOP_HOME/bin/hdfs --daemon start datanode $DN_CONF_OPTS
- $HADOOP_HOME/bin/hdfs dfsadmin -report
+ bash $HADOOP_HOME/bin/hdfs --daemon start datanode $DN_CONF_OPTS
+ bash $HADOOP_HOME/bin/hdfs dfsadmin -report
}
setup_hdfs () {
echo "::warning::docker_test_java17.sh copying hadoop conf"
mv /opt/bundle-validation/tmp-conf-dir/hdfs-site.xml
$HADOOP_HOME/etc/hadoop/hdfs-site.xml
mv /opt/bundle-validation/tmp-conf-dir/core-site.xml
$HADOOP_HOME/etc/hadoop/core-site.xml
- $HADOOP_HOME/bin/hdfs namenode -format
- $HADOOP_HOME/bin/hdfs --daemon start namenode
- echo "::warning::docker_test_java17.sh starting hadoop hdfs"
- $HADOOP_HOME/sbin/start-dfs.sh
+ mkdir -p $DOCKER_TEST_DIR/pid
+ export HADOOP_PID_DIR=$DOCKER_TEST_DIR/pid
- # start datanodes
+ bash $HADOOP_HOME/bin/hdfs namenode -format
+ bash $HADOOP_HOME/bin/hdfs --daemon start namenode
+
+ echo "::warning::docker_test_java17.sh waiting for NameNode to start"
+ NAMENODE_READY=0
Review Comment:
@linliu-code : same here. can you raise a separate PR against 0.14.2-prep
branch for the docker related changes and get it landed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
