prashantwason commented on PR #18384: URL: https://github.com/apache/hudi/pull/18384#issuecomment-4157021429
@suryaprasanna Thanks for the review! I've addressed all the feedback: **Changes in latest commit:** - Renamed `populateField` → `populateIndividualMetaFields` across all 9 files - Made `getMetaFieldsToExclude()` private (only used internally) - Added `withMetaFieldsToExclude()` builder method for test convenience **Unit tests added:** - 8 tests in `TestHoodieWriteConfig` covering `getMetaFieldPopulationFlags()`: default behavior, populateMetaFields=false, selective exclusion, exclude all, single field exclusion, whitespace handling, invalid field names, empty list - 1 integration test in `TestHoodieRowCreateHandle` (`testSelectiveMetaFieldPopulation`) that writes with excluded fields and verifies null values in parquet output **On OPERATION_METADATA_FIELD:** It's not part of the standard 5 `HOODIE_META_COLUMNS` — it's in the separate `HOODIE_META_COLUMNS_WITH_OPERATION` set and marked as temporary. No change needed. **On table version upgrade:** `hoodie.meta.fields.to.exclude` is a table config property in `hoodie.properties`, not a schema/format change. Existing tables without this property behave identically. Since it's purely additive, a table version upgrade shouldn't be required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
