cshuo commented on code in PR #18539:
URL: https://github.com/apache/hudi/pull/18539#discussion_r3245310797
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetSchemaConverter.java:
##########
@@ -49,6 +49,17 @@
/**
* Schema converter converts Parquet schema to and from Flink internal types.
*
+ * <p>On reads, this converter performs best-effort physical type mapping. It
detects the
+ * Parquet {@code VARIANT} annotation and will reject shredded variants. Blob
and Vector types
+ * cannot be distinguished from ordinary binary columns via Parquet schema
alone.
+ *
+ * <p>On writes, this converter maps Flink {@code VariantType} to the
canonical unshredded Parquet
+ * layout (group with binary metadata + value fields). The VARIANT logical
type annotation is
+ * resolved by {@link DataTypeAdapter#variantParquetAnnotation()} — on Flink
2.1+ with
+ * parquet-java 1.16.0+ the annotation is attached automatically; on pre-2.1
Flink or with
Review Comment:
1.16 or 1.15.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
