shangxinli commented on code in PR #18765: URL: https://github.com/apache/hudi/pull/18765#discussion_r3277722978
########## hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/WriteErrorReporter.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.utilities.streamer; + +import org.apache.hudi.client.WriteStatus; + +import lombok.extern.slf4j.Slf4j; + +import java.util.List; + +/** + * Logs the first N errored write statuses so the operator can triage a failed commit. + * + * <p>Extracted from {@code HoodieStreamerWriteStatusValidator} (#18750).</p> + */ Review Comment: Done in 140e17f. Dropped `lombok.extern.slf4j.Slf4j` from both `WriteErrorReporter` and `SparkWriteErrorValidator` and added explicit `private static final Logger LOG = LoggerFactory.getLogger(<class>.class);` declarations. Updated all `log.{info,warn,error,trace}` call sites in both files to `LOG.*` so they read the same as `StreamSync` and the rest of the streamer package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
