nsivabalan commented on code in PR #18384:
URL: https://github.com/apache/hudi/pull/18384#discussion_r3291248907
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -795,6 +795,11 @@ protected HoodieTable
createTableAndValidate(HoodieWriteConfig config,
if (!skipValidation) {
CommonClientUtils.validateTableVersion(table.getMetaClient().getTableConfig(),
config);
}
+ // Overlay the persisted POPULATE_META_FIELDS and META_FIELDS_EXCLUDE_LIST
onto the
+ // shared writer config so table services (clustering/compaction/clean)
see the on-disk
+ // state. Safe to mutate in place: these properties are immutable for the
lifetime of
+ // the table. Mirrors the same step in
BaseHoodieWriteClient.createTableAndValidate.
+ table.getMetaClient().getTableConfig().overlayMetaFieldProps(config);
Review Comment:
unfortunately, HoodieTableConfig is not required to build HoodieWriteConfig.
and hence I resorted to updating HoodieWriteConfig w/ hoodie properties from
HoodieTableConfig in my earlier attempt.
I feel, we can go w/ what we have currently. I will revisit on passing the
HoodieTableConfig around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
