danny0405 commented on code in PR #18944:
URL: https://github.com/apache/hudi/pull/18944#discussion_r3389502501
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/BaseHoodieLogRecordReader.java:
##########
@@ -89,13 +90,16 @@ public abstract class BaseHoodieLogRecordReader<T> {
protected final HoodieReaderContext<T> readerContext;
protected final HoodieTableMetaClient hoodieTableMetaClient;
// Merge strategy to use when combining records from log
+ @Getter(AccessLevel.PROTECTED)
private final String payloadClassFQN;
// Record's key/partition-path fields
private final String recordKeyField;
// Partition name override
+ @Getter
private final Option<String> partitionNameOverrideOpt;
Review Comment:
This changes the public accessor from `getPartitionNameOverride()` to Lombok
generated `getPartitionNameOverrideOpt()` because the field is named
`partitionNameOverrideOpt`. `AbstractHoodieLogRecordScanner` still keeps the
original `getPartitionNameOverride()` method, so this reader should likely
preserve the same source-compatible method as well, either by adding the
explicit getter back or suppressing Lombok on this field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
