voonhous commented on code in PR #18944: URL: https://github.com/apache/hudi/pull/18944#discussion_r3393176588
########## hudi-common/src/main/java/org/apache/hudi/common/table/read/BufferedRecord.java: ########## @@ -23,52 +23,38 @@ import org.apache.hudi.common.schema.HoodieSchema; import org.apache.hudi.common.util.OrderingValues; +import lombok.AllArgsConstructor; +import lombok.EqualsAndHashCode; +import lombok.Getter; +import lombok.Setter; + import javax.annotation.Nullable; import java.io.Serializable; -import java.util.Objects; import java.util.function.UnaryOperator; /** * Buffered Record used by file group reader. * * @param <T> The type of the engine specific row. */ +@AllArgsConstructor +@Getter +@EqualsAndHashCode Review Comment: Good catch. Lombok has no option to generate `getClass()` based equality (it always uses `instanceof` + `canEqual`), so I have restored the explicit `equals`/`hashCode` and dropped `@EqualsAndHashCode` on this class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
