danny0405 commented on code in PR #18963:
URL: https://github.com/apache/hudi/pull/18963#discussion_r3392716450
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -105,6 +106,43 @@ private static boolean
deleteFileAndGetResult(HoodieStorage storage, String dele
}
}
+ private static boolean deleteDirAndGetResult(HoodieStorage storage, String
deleteDirStr) {
Review Comment:
can we combine this method with deleteFileAndGetResult, they look pretty
much the same, maybe an explicit param to mark whether the path is a directory?
that would also makes the smallest change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
