voonhous commented on code in PR #18963:
URL: https://github.com/apache/hudi/pull/18963#discussion_r3393282762
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -105,6 +106,43 @@ private static boolean
deleteFileAndGetResult(HoodieStorage storage, String dele
}
}
+ private static boolean deleteDirAndGetResult(HoodieStorage storage, String
deleteDirStr) {
Review Comment:
Combined them into a single `deleteAndGetResult(storage, path, isDirectory)`
with the two call sites passing the path type explicitly. The only differences
between the two variants were the `deleteFile`/`deleteDirectory` call and the
log wording, both of which now derive from the flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
