nbalajee commented on a change in pull request #2607:
URL: https://github.com/apache/hudi/pull/2607#discussion_r595527836
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java
##########
@@ -113,13 +121,15 @@ public void write(HoodieRecord record,
Option<IndexedRecord> avroRecord) {
Option recordMetadata = record.getData().getMetadata();
try {
if (avroRecord.isPresent()) {
+ writeTimer.startTimer();
Review comment:
Fixed.
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java
##########
@@ -70,25 +72,32 @@
AbstractHoodieWriteClient<T, JavaRDD<HoodieRecord<T>>, JavaRDD<HoodieKey>,
JavaRDD<WriteStatus>> {
private static final Logger LOG =
LogManager.getLogger(SparkRDDWriteClient.class);
+ protected final transient HoodieObservabilityMetrics observabilityMetrics;
public SparkRDDWriteClient(HoodieEngineContext context, HoodieWriteConfig
clientConfig) {
- super(context, clientConfig);
+ this(context, clientConfig, Option.empty());
}
@Deprecated
public SparkRDDWriteClient(HoodieEngineContext context, HoodieWriteConfig
writeConfig, boolean rollbackPending) {
- super(context, writeConfig);
+ this(context, writeConfig, rollbackPending, Option.empty());
}
@Deprecated
public SparkRDDWriteClient(HoodieEngineContext context, HoodieWriteConfig
writeConfig, boolean rollbackPending,
Option<EmbeddedTimelineService> timelineService) {
super(context, writeConfig, timelineService);
+ this.observabilityMetrics = (HoodieObservabilityMetrics)
Registry.getRegistry(
+ HoodieObservabilityStat.OBSERVABILITY_REGISTRY_NAME,
HoodieObservabilityMetrics.class.getName());
+ observabilityMetrics.registerWithSpark(context, config);
}
public SparkRDDWriteClient(HoodieEngineContext context, HoodieWriteConfig
writeConfig,
Option<EmbeddedTimelineService> timelineService) {
super(context, writeConfig, timelineService);
+ this.observabilityMetrics = (HoodieObservabilityMetrics)
Registry.getRegistry(
Review comment:
Moved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
