nsivabalan commented on code in PR #18378:
URL: https://github.com/apache/hudi/pull/18378#discussion_r3450033534
##########
hudi-common/src/main/java/org/apache/hudi/common/util/PartitionPathEncodeUtils.java:
##########
@@ -56,6 +56,7 @@ public class PartitionPathEncodeUtils {
charToEscapeFilename.set('_');
charToEscapeFilename.set('-');
+ charToEscapeFilename.set('.');
Review Comment:
Thanks for flagging. There's no backwards-compat concern here: partitioned
RLI for partition values containing a literal `.` (e.g. `fare.currency=USD`)
was previously non-functional — the dot collided with `LOG_FILE_PATTERN`'s
parser, so MDT entries for such tables couldn't be produced or read. There are
no pre-existing encodings on disk that this change could invalidate. Added an
inline comment in `PartitionPathEncodeUtils` explaining this so future readers
see the rationale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
