nsivabalan commented on PR #18378: URL: https://github.com/apache/hudi/pull/18378#issuecomment-4765378337
Rebased onto latest master and replied to each of the open inline threads: - **Backward compatibility for adding `.` to escape list**: non-issue. Partitioned RLI for partition values containing a literal `.` was previously non-functional — the dot collided with `LOG_FILE_PATTERN`'s parser, so MDT entries for such tables couldn't be produced or read. There are no pre-existing on-disk encodings this change could invalidate. Added an inline comment in `PartitionPathEncodeUtils` documenting this. - **USD-only test assertion**: verified deterministic. `HoodieTestDataGenerator.generateFareNestedValues` hard-codes `currency="USD"`, so all 10 generated records land in `fare.currency=USD`. Added a comment near the assertion explaining this. - **Dead nonEmpty guard**: removed in 38d8abc. - **Misleading "both partitions" comment**: updated to refer only to the USD partition. Ready for review. @yihua @cshuo PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
