nsivabalan commented on PR #18803: URL: https://github.com/apache/hudi/pull/18803#issuecomment-4765378423
Rebased onto latest master. PR title (`minor:` → `[MINOR] ...`) and body fixed to match the template. All open feedback addressed: - `HoodieMetadataConfig.shouldEnableDetailedMetrics()` → `isDetailedMetricsEnabled()` (matches `isMetricsEnabled` sibling); all 7 callers updated. - Builder param `enableMetrics` → `enable` to avoid visual collision with the separate `enableMetrics()` builder method. - Expanded `ENABLE_DETAILED_METRICS` documentation to name what "detailed" includes (per-MDT-partition file size + base/log file counts) and the driver-memory tradeoff. - Earlier-round items also in: field/method rename (`detailedMetricsEnabled` / `isDetailedMetricsEnabled`), sinceVersion bumped to 1.3.0, Spark TestHoodieMetadataBase mirrored from the java-client base, nested `ifPresent` to avoid double `.get()`. CI: a few Spark java17 part1 jobs were cancelled because spark4.2 build died on a transient Maven Central download (`icu4j:58.1` truncated). Infra flake, not a code issue. Ready for review. @yihua @danny0405 PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
