hudi-agent commented on code in PR #18803:
URL: https://github.com/apache/hudi/pull/18803#discussion_r3461630276
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -683,6 +683,15 @@ public final class HoodieMetadataConfig extends
HoodieConfig {
+ "with the actual record count stored in the metadata table. This
validation runs in a distributed manner "
Review Comment:
🤖 nit: the existing constant in this class is `METRICS_ENABLE` (noun-first),
but the new one is `ENABLE_DETAILED_METRICS` (verb-first). Could you flip it to
`DETAILED_METRICS_ENABLE` — and adjust the key string from
`.enable.detailed.metrics` to `.detailed.metrics.enable` — so both the Java
name and the config key follow the same noun-then-verb convention?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -683,6 +683,13 @@ public final class HoodieMetadataConfig extends
HoodieConfig {
+ "with the actual record count stored in the metadata table. This
validation runs in a distributed manner "
+ "using the compute engine. Disabled by default as it adds overhead
to the initialization process.");
+ public static final ConfigProperty<Boolean> ENABLE_DETAILED_METRICS =
ConfigProperty
+ .key(METADATA_PREFIX + ".enable.detailed.metrics")
+ .defaultValue(false)
+ .markAdvanced()
+ .sinceVersion("0.14.2")
Review Comment:
🤖 If this is about the `sinceVersion("0.14.2")` on the new config — that
does look off. This is a brand-new config being added on a 1.3.0-SNAPSHOT line,
so it should carry the current targeting release rather than 0.14.2 (which
would imply it has existed since that release). Worth bumping to match the
other recently-added configs here (1.1.0/1.2.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
