voonhous commented on code in PR #18837:
URL: https://github.com/apache/hudi/pull/18837#discussion_r3465725419
##########
pom.xml:
##########
@@ -130,6 +129,12 @@
<hive.avro.version>1.11.4</hive.avro.version>
<presto.version>0.273</presto.version>
<trino.version>390</trino.version>
+ <!-- Trino SPI version that hudi-trino-plugin main code compiles against.
-->
+ <trino.connector.version>481</trino.connector.version>
+ <!-- Trino version used by the hudi-trino-tests profile for *-tests.jar
classifier deps.
+ Trino does not publish trino-spi / trino-filesystem / trino-hive
test-jars; the
+ profile is opt-in and assumes a locally-built Trino snapshot in
~/.m2. -->
+ <trino.connector.test.version>481</trino.connector.test.version>
Review Comment:
Let me double check this. I am against pinning
`<trino.version>390</trino.version>` as this causes quite abit of confusion.
I can't remember why i added this, might because of compilation error or
test failures. Will double check and report back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
