voonhous commented on code in PR #18837: URL: https://github.com/apache/hudi/pull/18837#discussion_r3466820647
########## hudi-trino-plugin/pom.xml: ########## @@ -1,31 +1,142 @@ <?xml version="1.0" encoding="UTF-8"?> -<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> <modelVersion>4.0.0</modelVersion> <parent> - <groupId>io.trino</groupId> - <artifactId>trino-root</artifactId> - <version>472</version> - <!-- Stop looking for the parent on local file system --> - <relativePath /> + <groupId>org.apache.hudi</groupId> + <artifactId>hudi</artifactId> + <version>1.3.0-SNAPSHOT</version> + <relativePath>../pom.xml</relativePath> </parent> - <artifactId>trino-hudi</artifactId> - <packaging>trino-plugin</packaging> - <description>Trino - Hudi connector</description> + <!-- Source dir is hudi-trino-plugin/ but artifactId is hudi-trino per RFC-105. --> Review Comment: Good idea — renamed `hudi-trino-plugin/` → `hudi-trino/` so the directory matches the `hudi-trino` artifactId (and Hudi's dir==artifactId convention), and dropped the pom/README comments that were there only to flag the mismatch. Updated the root pom module entry, the two Trino CI workflows (path filters + `-pl` targets), the checkstyle suppression, the source-copyright exclusion, the README, and the enforcer message. One thing I kept as-is: the `test-hudi-trino-plugin` CI check name. It's already a required status check in `.asf.yaml` on master, so renaming it in this PR would leave the required context unsatisfiable. Happy to rename it to `test-hudi-trino` in a follow-up once the `.asf.yaml`/branch-protection side is updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
