voonhous commented on code in PR #18837: URL: https://github.com/apache/hudi/pull/18837#discussion_r3628337205
########## .github/workflows/hudi_trino_ci.yml: ########## @@ -0,0 +1,67 @@ +name: Hudi Trino Connector CI + +on: + push: + branches: + - master + - 'release-*' + paths: + - 'hudi-trino/**' + - '.github/workflows/hudi_trino_ci.yml' + pull_request: + branches: + - master + - 'release-*' + paths: + - 'hudi-trino/**' Review Comment: Good catch -- confirmed, `test-hudi-trino-plugin` is required in `.asf.yaml` and a path-filtered workflow is never instantiated, so the context would sit pending forever. Fixed: - Dropped `paths:` from the `pull_request` trigger, so the workflow runs on every PR. - Added a `detect-trino-changes` job; all 8 steps in `test-hudi-trino-plugin` are now guarded by `if: needs.changes.outputs.trino == 'true'`, same shape as `bot.yml`'s `needs.changes`. - Kept `paths:` on the `push:` trigger -- required checks only apply to PRs. Net effect: the check reports on every PR, and no-ops green when nothing under `hudi-trino/` changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
