voonhous commented on code in PR #18837:
URL: https://github.com/apache/hudi/pull/18837#discussion_r3628359716
##########
hudi-trino/src/main/java/io/trino/plugin/hudi/HudiTableHandle.java:
##########
@@ -248,6 +261,18 @@ public TupleDomain<HiveColumnHandle> getRegularPredicates()
return regularPredicates;
}
+ @JsonProperty
+ public OptionalLong getLimit()
+ {
+ return limit;
+ }
+
+ @JsonProperty
+ public List<HiveColumnHandle> getOrderingColumns()
Review Comment:
Agreed, the name understated what it holds. Renamed:
- `lazyOrderingColumns` -> `lazyMergeRequiredColumns`
- `getOrderingColumns()` -> `getMergeRequiredColumns()`
- `@JsonProperty("orderingColumns")` ->
`@JsonProperty("mergeRequiredColumns")`
- `HudiUtil.prependHudiMetaAndOrderingColumns` ->
`prependHudiMetaAndMergeRequiredColumns` (same misnomer, it prepends this list)
Also added javadoc on the getter pointing at `getMergeRequiredColumnHandles`
so the CUSTOM-merger contribution is stated at the field rather than only at
the producer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
