voonhous opened a new pull request, #19455:
URL: https://github.com/apache/hudi/pull/19455
#19132 pruned the forked parser to Hudi-routed statements; remove the code
that became unreachable in the six HoodieSpark*ExtendedSqlAstBuilders
(3.3/3.4/3.5/4.0/4.1/4.2):
- uncalled methods: createSchema, createStructType and both
visitPropertyKeys overloads (scaladoc references updated)
- visitBooleanLiteral: unreachable from SQL in both keyword modes.
TRUE/FALSE are ansiNonReserved, so a bare true/false in transform-argument
position always parses as a column reference, and OPTIONS/TBLPROPERTIES boolean
values go through getText without visiting the constant. visitNullLiteral
stays: under ANSI keyword mode f(null, id) parses as a null literal.
- branches the grammar cannot produce: getSingleFieldReference's
empty-arguments arm (the transform rule requires at least one argument),
visitTransformArgument's getOrElse(throw ...) (a transformArgument is always
qualifiedName or constant), visitCreateFileFormat's trailing case _ (STORED AS
and STORED BY are mutually exclusive grammar alternatives)
- unused imports, including ParserUtils.entry which is shadowed by an
identical local def in visitRowFormatDelimited
Deliberately kept, deviating from the issue: the case _ arm of
validateRowFormatFileFormat. It is reachable, e.g. via CREATE TABLE t (b BLOB)
ROW FORMAT SERDE 'x' STORED BY 'y': rowFormat and createFileFormat coexist in
createTableClauses, STORED BY leaves createFileFormatCtx.fileFormat null, and
(rowFormatCtx, null) falls past the three typed arms. Removing it would turn a
clean ParseException into a scala.MatchError.
Fixes #19451
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
