voonhous commented on code in PR #19455:
URL: https://github.com/apache/hudi/pull/19455#discussion_r3698318409
##########
hudi-spark-datasource/hudi-spark3.5.x/src/main/scala/org/apache/spark/sql/parser/HoodieSpark3_5ExtendedSqlAstBuilder.scala:
##########
@@ -988,8 +945,7 @@ class HoodieSpark3_5ExtendedSqlAstBuilder(conf: SQLConf,
delegate: ParserInterfa
val literal = Option(ctx.constant)
.map(typedVisit[Literal])
.map(lit => LiteralValue(lit.value, lit.dataType))
- reference.orElse(literal)
- .getOrElse(throw new ParseException("Invalid transform argument", ctx))
+ reference.orElse(literal).get
Review Comment:
Addressed in 9f6cd85f5966: `visitBooleanLiteral` restored in all six
builders (scaladoc now records the reachability constraint), the
`TestBlobDataType` comment corrected, and an ANSI-mode regression added
asserting `false` yields a `BooleanType` literal while `true` stays a column
reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
