hudi-agent commented on code in PR #19492:
URL: https://github.com/apache/hudi/pull/19492#discussion_r3704136870
##########
hudi-io/pom.xml:
##########
@@ -116,6 +116,12 @@
<goal>shade</goal>
</goals>
<configuration>
+ <!-- Must stay false here, and only here. This is the one module
using
Review Comment:
🤖 nit: this comment runs a bit long — the last sentence ("it is not a
leftover to be 'fixed' by analogy with the packaging bundles") reads as a
defensive aside rather than useful context. Could you trim it to just the
invariant, e.g. `<!-- shadedArtifactAttached=true publishes the shaded jar
under the "shaded" classifier while the primary jar stays unshaded, so the
published POM must still declare protobuf-java; reducing it would strip a real
runtime dependency. -->`?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
