rangareddy commented on code in PR #19492:
URL: https://github.com/apache/hudi/pull/19492#discussion_r3709859120
##########
hudi-io/pom.xml:
##########
@@ -116,6 +116,10 @@
<goal>shade</goal>
</goals>
<configuration>
+ <!-- shadedArtifactAttached publishes the shaded jar under the
"shaded" classifier while the
+ primary jar stays unshaded, so the published POM must still
declare protobuf-java;
Review Comment:
Trimmed again — down to the single non-obvious fact, and the "iff"
construction is gone:
```xml
<!-- The shaded jar is attached under the "shaded" classifier and the
primary jar stays
unshaded, so the published POM must keep declaring protobuf-java:
reducing it would strip
a dependency the primary jar really needs. -->
```
I dropped the "why the packaging bundles differ" clause entirely this time.
It was there because #19466 asked the comment to stop someone "fixing" this by
analogy with the bundles, but you are right that it was carrying the parse
difficulty for little gain — the classifier sentence already implies the
bundles are a different case, since none of them attaches a classifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
