hudi-agent commented on code in PR #19518:
URL: https://github.com/apache/hudi/pull/19518#discussion_r3720782954
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -191,7 +191,8 @@ private static DataStream<RowData> bucketShuffleAndSort(
if (isLsmTreeStorageLayout) {
RowType sortRowType =
- LsmBucketBulkInsertWriterHelper.rowTypeWithFileIdAndKey(rowType);
+ LsmBucketBulkInsertWriterHelper.rowTypeWithFileIdAndKey(
+ rowType, needFixedFileIdSuffix);
Review Comment:
🤖 nit: these helpers take a param named `isNonBlockingConcurrencyControl`,
but here you're passing `needFixedFileIdSuffix`. Even if the two coincide
today, conflating them makes this harder to reason about later — could you
align the naming (or pass the NBCC flag explicitly)?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
