hudi-agent commented on code in PR #19518:
URL: https://github.com/apache/hudi/pull/19518#discussion_r3726720339
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bucket/BucketBulkInsertWriterHelper.java:
##########
@@ -125,12 +142,24 @@ public static RowData rowWithFileId(Map<String, String>
bucketIdToFileId, RowDat
indexKeyFields,
numBucketsFunction,
needFixedFileIdSuffix);
- return GenericRowData.of(StringData.fromString(fileId), record);
+ return needFixedFileIdSuffix
+ ? GenericRowData.of(
Review Comment:
🤖 nit: `needFixedFileIdSuffix` is used here (and in
`LsmBucketBulkInsertWriterHelper.rowWithFileIdAndKey`) as a stand-in for the
NBCC flag, while every other new method in this PR names the same concept
`isNonBlockingConcurrencyControl`. A future reader has to independently verify
these are always equivalent. Could you rename the parameter to
`isNonBlockingConcurrencyControl` (or at least add a brief inline comment) to
make the connection explicit?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
