rangareddy commented on PR #19590:
URL: https://github.com/apache/hudi/pull/19590#issuecomment-5263412148

   Superseded — this duplicates **#9056**, "[HUDI-6456] [DOC] Add parquet 
blooms documentation" by @parisni, which has been open since 2023-06-26 and is 
the original work for #16063. parisni wrote the parquet bloom support itself 
(#8716), so that PR should land, not this one.
   
   I missed it when I opened this: I looked for cross-referenced PRs on the 
issue timeline, and because #9056 predates the JIRA-migrated issue it never 
linked there — even though hudi-bot had posted a "Linked PR(s)" comment naming 
it on #16063. The lesson for me is that the timeline is not a sufficient check 
for migrated issues.
   
   I have moved the material worth keeping onto #9056 as review comments rather 
than leaving it here: the `hoodie.parquet.bloom.filter.enabled` name collision, 
the silently-swallowed reflection failure, a correction to the COW-only 
limitation (MOR base files go through the same writer; it is the log blocks 
that miss out), a version typo, and the fact that a feature shipped since 
0.14.0 wants the versioned copies too.
   
   Leaving this open only so a committer can compare shapes — #9056 adds a 
dedicated `parquet_bloom.md` page, this one adds a section to `performance.md` 
next to Data Skipping. If the page is preferred, which I would expect, please 
close this in favour of #9056.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to