rangareddy commented on PR #19590:
URL: https://github.com/apache/hudi/pull/19590#issuecomment-5263499949
Updating this PR rather than closing it, which retracts the "please close
this in favour of #9056" line in my previous comment — that recommendation no
longer stands, and I would rather correct it here than leave a reviewer acting
on it.
**Extended to every supported release.** The section now lands in the
current docs plus all five supported versioned copies — 1.2.0, 1.1.1, 1.0.2,
1.0.1 and 1.0.0 — because the feature exists in all of them. Previously it was
only `docs/` + 1.2.0, which was too narrow: I had followed #19572's file set,
but that PR documented a table service whose page is 1.2-specific, whereas this
is a feature that has shipped since 0.14.0.
Checked rather than assumed, per version:
* `handleParquetBloomFilters` is **absent** at `release-0.13.1` and present
from `release-0.14.0` onward, so every versioned copy on the site (all ≥
0.14.0) has the feature.
* the `hoodie.parquet.bloom.filter.enabled` config this section contrasts
against reads `defaultValue(true)` / `sinceVersion("0.15.0")` identically at
`release-1.0.0`, `1.0.2`, `1.1.1` and `1.2.0` — so the admonition is accurate
in each version it lands in, not just on master.
* the five-version fan-out matches how other cross-version docs fixes have
been applied here (#19555, #19459).
One structural difference worth flagging for review:
**`version-1.0.0/performance.md` has no `## Related Resources` heading** — that
page simply ends after Data Skipping — so there the section is appended at the
end of the file, while in the other five it is inserted before that anchor. The
inserted text itself is byte-identical in all six.
I left 0.15.x and 0.14.x alone deliberately: they have had no, or nearly no,
doc commits in the last six months and are effectively frozen. Happy to extend
to them if the project would rather have full coverage.
Re-validated after the change, across all six files: `markdownlint`
introduces no new class of finding (compared by rule class, since these pages
already carry ~7 classes including 237 `MD013`s), every `<column>` sits inside
inline code so nothing new reaches the MDX parser, and `indexes.md` exists in
each of the five versioned trees so the relative link resolves everywhere.
@parisni — #9056 is still the original and my review comments there stand on
their own; if a committer prefers your dedicated page, I am glad to fold this
content into it and close this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
