deepakpanda93 commented on code in PR #19494: URL: https://github.com/apache/hudi/pull/19494#discussion_r3783849766
########## hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestLogAppender.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.testutils; + +import org.apache.logging.log4j.core.LogEvent; +import org.apache.logging.log4j.core.Logger; +import org.apache.logging.log4j.core.appender.AbstractAppender; + +import java.util.ArrayList; +import java.util.List; +import java.util.UUID; + +/** + * Collects the log events a logger emits, so a test can assert on what was logged. + * <p> + * Attach it around the code under test and detach it afterwards: + * <pre>{@code + * HoodieTestLogAppender appender = new HoodieTestLogAppender(); + * appender.attachTo(SomeClass.class); + * try { + * // exercise the code + * } finally { + * appender.detach(); + * } + * }</pre> + * Named so that surefire does not mistake it for a test class. + */ +public class HoodieTestLogAppender extends AbstractAppender { + + private final List<LogEvent> log = new ArrayList<>(); + private Logger attachedLogger; + + public HoodieTestLogAppender() { + super(UUID.randomUUID().toString(), null, null, false, null); + } + + @Override + public void append(LogEvent event) { + // the event is mutable and gets reused, so keep an immutable copy + log.add(event.toImmutable()); + } + + public List<LogEvent> getLog() { + return new ArrayList<>(log); + } + + /** + * Starts this appender and attaches it to the logger of the given class. + */ + public HoodieTestLogAppender attachTo(Class<?> clazz) { Review Comment: Done in `65f99a982c0d`. `LogManager` is imported now and the line reads: ```java attachedLogger = (Logger) LogManager.getLogger(clazz); ``` Worth noting why it was qualified in the first place: this class already imports `org.apache.logging.log4j.core.Logger`, and I wanted to be sure adding `org.apache.logging.log4j.LogManager` did not collide with it. The simple names differ, so there is no clash and the import is clean. Also rebased onto master in the same push. The branch had drifted 37 commits behind; GitHub still reported it mergeable, but CI results against a base that stale are not worth much. The rebase was clean, no conflicts. Re-verified after both changes: `TestRetryHelper` 4/4, `TestHoodiePartitionMetadata` 8/8, and `checkstyle:check` plus `apache-rat:check` clean on `hudi-common` and `hudi-hadoop-common`. Checkstyle was the one to watch here, since a new import has to land in the right group for the `ImportOrder` rule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
