hudi-agent commented on code in PR #19494: URL: https://github.com/apache/hudi/pull/19494#discussion_r3786297463
########## hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestLogAppender.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.testutils; + +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.core.LogEvent; +import org.apache.logging.log4j.core.Logger; +import org.apache.logging.log4j.core.appender.AbstractAppender; + +import java.util.ArrayList; +import java.util.List; +import java.util.UUID; + +/** + * Collects the log events a logger emits, so a test can assert on what was logged. + * <p> + * Attach it around the code under test and detach it afterwards: + * <pre>{@code + * HoodieTestLogAppender appender = new HoodieTestLogAppender(); + * appender.attachTo(SomeClass.class); + * try { + * // exercise the code + * } finally { + * appender.detach(); + * } + * }</pre> + * Named so that surefire does not mistake it for a test class. + */ +public class HoodieTestLogAppender extends AbstractAppender { + + private final List<LogEvent> log = new ArrayList<>(); Review Comment: 🤖 nit: could you rename `log` to `capturedEvents` (or just `events`)? In a class that is itself a log appender, `log` reads like a logger field at a quick glance, and `getLog()` returning a `List` is a small double-take that `getCapturedEvents()` would avoid. <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
