wombatu-kun commented on code in PR #19642:
URL: https://github.com/apache/hudi/pull/19642#discussion_r3794492275
##########
hudi-trino/src/main/java/io/trino/plugin/hudi/HudiSplitSource.java:
##########
@@ -188,7 +168,13 @@ public void close()
@Override
public boolean isFinished()
{
- return splitLoaderFuture.isDone() && queue.isFinished();
+ return finished.get() || (splitLoaderFuture.isDone() &&
queue.isFinished());
Review Comment:
`HudiBackgroundSplitLoader.generateSplits` also finishes the queue from its
`whenAllComplete` combiner, and Guava does not order that against the
per-future `addExceptionCallback` that sets `trinoException`, so a failure in
the last generator future can still land after `isFinished()` has answered
true. Have the combiner surface the futures' failures before
`asyncQueue.finish()`, and cover it in the same `HudiSplitSource` unit test;
narrow race, not a blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
