voonhous commented on code in PR #19642: URL: https://github.com/apache/hudi/pull/19642#discussion_r3794225676
########## docker/trino/build_image.sh: ########## @@ -15,21 +15,21 @@ # See the License for the specific language governing permissions and # limitations under the License. -# Builds the apachehudi/hudi-trino_<version> image with a locally-built -# trino-hudi plugin baked in. The plugin dir (typically the in-repo shim's +# Builds the apachehudi/hudi-trino-e2e image with a locally-built trino-hudi +# plugin baked in. The plugin dir (typically the in-repo shim's # docker/trino/shim/target/trino-hudi-<v>, see docker/trino/shim/pom.xml) is # staged into the build context at docker/trino/plugin/ (gitignored), then # baked into the image. # Usage: ./build_image.sh --plugin-dir <path> [--trino-version <v>] [--image-tag <t>] -# Typical: ./build_image.sh --plugin-dir "$(dirname "$0")/shim/target/trino-hudi-481" -# Note: --trino-version must match the shim pom's parent version and the root -# pom's trino.version property. +# Typical: ./build_image.sh --plugin-dir "$(dirname "$0")/shim/target/trino-hudi-<trino.version>" +# Note: --trino-version is the released Trino server image to build on top of +# (the root pom's trino.e2e.version), not the version the plugin was built at. set -e # Default values PLUGIN_DIR="" -TRINO_VERSION="481" +TRINO_VERSION="483" Review Comment: Took the first option in 651552d59bd5: `build_image.sh` now derives its default from the root pom's `trino.e2e.version` with the same sed the workflows use (loud error if unreadable), so the README claim stays true without teaching the bot more files. The Dockerfile `ARG` default is unreachable from any scripted path -- the script always passes `--build-arg` -- so it stays a plain fallback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
