prashantwason commented on PR #19661: URL: https://github.com/apache/hudi/pull/19661#issuecomment-5331787557
<h2 dir="auto" style="box-sizing: border-box; margin-top: 0px !important; margin-bottom: 16px; font-size: 1.5em; font-weight: 600; line-height: 1.25; border-bottom: 1px solid rgba(209, 217, 224, 0.7); padding-bottom: 0.3em; color: rgb(31, 35, 40); font-family: "Mona Sans VF", -apple-system, "system-ui", "Segoe UI", "Noto Sans Backtick Fix", "Noto Sans", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: normal; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;">extraMetadata Coverage Across All Instant Types</h2><markdown-accessiblity-table data-catalyst="" style= "box-sizing: border-box; display: block; color: rgb(31, 35, 40); font-family: "Mona Sans VF", -apple-system, "system-ui", "Segoe UI", "Noto Sans Backtick Fix", "Noto Sans", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: normal; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;"> Instant | Requested | Inflight | Completed -- | -- | -- | -- commit | empty marker | empty marker | YES — updateExtraMetadata() in commitStats() deltacommit | empty marker | empty marker | YES — same path as commit replacecommit (insert_overwrite) | empty marker | empty marker | YES — same write-commit path compaction | YES — HoodieCompactionPlan.extraMetadata | marker transition | YES — CompactHelpers re-reads plan log_compaction | YES — same HoodieCompactionPlan | marker transition | YES — same as compaction clustering (replacecommit) | YES — HoodieClusteringPlan.extraMetadata | marker transition | YES — fixed: plan extraMetadata now re-merged clean | YES — fixed: HoodieCleanerPlan.extraMetadata now wired | marker transition | YES — CleanActionExecutor propagates from plan rollback | YES — new: HoodieRollbackPlan.extraMetadata | marker transition | YES — new: HoodieRollbackMetadata.extraMetadata from plan savepoint | N/A (no requested state) | empty marker | YES — new: enrich() called inline in executor restore | YES — new: HoodieRestorePlan.extraMetadata | marker transition | YES — new: HoodieRestoreMetadata.extraMetadata from plan indexing | NO | marker transition | NO </markdown-accessiblity-table><p dir="auto" style="box-sizing: border-box; margin-top: 0px; margin-bottom: 16px; color: rgb(31, 35, 40); font-family: "Mona Sans VF", -apple-system, "system-ui", "Segoe UI", "Noto Sans Backtick Fix", "Noto Sans", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: normal; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;"><strong style="box-sizing: border-box; font-weight: 600;">Legend:</strong></p><ul dir="auto" style="box-sizing: border-box; margin-top: 0px; margin-bottom: 16px; padding: 0px; posi tion: relative; color: rgb(31, 35, 40); font-family: "Mona Sans VF", -apple-system, "system-ui", "Segoe UI", "Noto Sans Backtick Fix", "Noto Sans", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: normal; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;"><li style="box-sizing: border-box; margin-left: 24px;"><strong style="box-sizing: border-box; font-weight: 600;">YES</strong><span> </span>= extraMetadata populated with hudi.version, engine, (opt-in) engine properties, config keys</li><li style="box-sizing: border-box; margin- top: 0.25em; margin-left: 24px;"><strong style="box-sizing: border-box; font-weight: 600;">fixed</strong><span> </span>= was missing before this change, now wired</li><li style="box-sizing: border-box; margin-top: 0.25em; margin-left: 24px;"><strong style="box-sizing: border-box; font-weight: 600;">new</strong><span> </span>= schema + code added in this change</li><li style="box-sizing: border-box; margin-top: 0.25em; margin-left: 24px;"><strong style="box-sizing: border-box; font-weight: 600;">empty marker</strong><span> </span>= no content written to instant file at this state</li><li style="box-sizing: border-box; margin-top: 0.25em; margin-left: 24px;"><strong style="box-sizing: border-box; font-weight: 600;">marker transition</strong><span> </span>= state change only, no content rewrite</li></ul><p dir="auto" style="box-sizing: border-box; margin-top: 0px; margin-bottom: 0px !important; color: rgb(31, 35, 40); font-family: "Mona Sans VF", -apple-system, "syst em-ui", "Segoe UI", "Noto Sans Backtick Fix", "Noto Sans", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 14px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: normal; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;"><strong style="box-sizing: border-box; font-weight: 600;">Indexing</strong><span> </span>is the only remaining instant type without extraMetadata support — it uses<span> </span><code class="notranslate" style="box-sizing: border-box; font-family: "Monaspace Neon", ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospa ce; font-size: 11.9px; tab-size: 4; white-space: break-spaces; background-color: rgba(129, 139, 152, 0.12); border-radius: 6px; margin: 0px; padding: 0.2em 0.4em;">HoodieIndexPlan</code>/<code class="notranslate" style="box-sizing: border-box; font-family: "Monaspace Neon", ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace; font-size: 11.9px; tab-size: 4; white-space: break-spaces; background-color: rgba(129, 139, 152, 0.12); border-radius: 6px; margin: 0px; padding: 0.2em 0.4em;">HoodieIndexCommitMetadata</code><span> </span>which don't have the field and weren't part of this change.</p> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
