prashantwason commented on PR #19661:
URL: https://github.com/apache/hudi/pull/19661#issuecomment-5331797516

   ## extraMetadata Coverage Across All Instant Types
   
   | Instant | Requested | Inflight | Completed |
   |---|---|---|---|
   | **commit** | empty marker | empty marker | YES — `updateExtraMetadata()` 
in `commitStats()` |
   | **deltacommit** | empty marker | empty marker | YES — same path as commit |
   | **replacecommit (insert_overwrite)** | empty marker | empty marker | YES — 
same write-commit path |
   | **compaction** | YES — `HoodieCompactionPlan.extraMetadata` | marker 
transition | YES — `CompactHelpers` re-reads plan |
   | **log_compaction** | YES — same `HoodieCompactionPlan` | marker transition 
| YES — same as compaction |
   | **clustering (replacecommit)** | YES — 
`HoodieClusteringPlan.extraMetadata` | marker transition | YES — **fixed**: 
plan extraMetadata now re-merged |
   | **clean** | YES — **fixed**: `HoodieCleanerPlan.extraMetadata` now wired | 
marker transition | YES — `CleanActionExecutor` propagates from plan |
   | **rollback** | YES — **new**: `HoodieRollbackPlan.extraMetadata` | marker 
transition | YES — **new**: `HoodieRollbackMetadata.extraMetadata` from plan |
   | **savepoint** | N/A (no requested state) | empty marker | YES — **new**: 
`enrich()` called inline in executor |
   | **restore** | YES — **new**: `HoodieRestorePlan.extraMetadata` | marker 
transition | YES — **new**: `HoodieRestoreMetadata.extraMetadata` from plan |
   | **indexing** | NO | marker transition | NO |
   
   **Legend:**
   - **YES** = extraMetadata populated with hudi.version, engine, (opt-in) 
engine properties, config keys
   - **fixed** = was missing before this change, now wired
   - **new** = schema + code added in this change
   - **empty marker** = no content written to instant file at this state
   - **marker transition** = state change only, no content rewrite
   
   **Indexing** is the only remaining instant type without extraMetadata 
support — it uses `HoodieIndexPlan`/`HoodieIndexCommitMetadata` which don't 
have the field and weren't part of this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to