voonhous commented on code in PR #19687:
URL: https://github.com/apache/hudi/pull/19687#discussion_r3850703069


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/schema/TestVariantDataType.scala:
##########
@@ -509,6 +407,16 @@ class TestVariantDataType extends HoodieSparkSqlTestBase {
 
           spark.sql(s"""update $tableName set v = 
parse_json('{"key":"value2"}'), ts = 1001 where id = 1""")
 
+          // Second update under the FLIPPED layout (session confs override 
tblproperties):
+          // the updated file's layout now differs from the write layout, the 
mixed-layout
+          // CDC case (images must survive whichever physical slot serves 
them).
+          withSQLConf(
+            "hoodie.parquet.variant.write.shredding.enabled" -> 
(!shredded).toString,

Review Comment:
   Pinned the flipped instant with 
`assertLayoutsByInstant(baseLayouts(tablePath), leg)`: unshredded when the 
table was shredded, `Some(Seq("key"))` otherwise.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to